Re: [PATCH] I2C Part 1 - Remove some redundancy from the i2c-core.c file

Hi Corey,

> Call i2c_transfer() from i2c_master_send() and i2c_master_recv()
> to avoid the redundant code that was in all three functions.

I like this. You're right, there is code duplication here, which we can
get rid of, so let's do so. I'd only have one comments about your patch:

You can get rid of the dev_dbg calls in i2c_master_send() and
i2c_master_recv() altogether IMHO. I recently updated i2c_transfer() to
make it more verbose in debug mode [1], so the debug messages in
i2c_master_send() and i2c_master_recv() are mostly redundant now as far
as I can see.

[1] http://archives.andrew.net.au/lm-sensors/msg29859.html

Thanks,
-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] I2C Part 1 - Remove some redundancy from the i2c-core.c file
    • From: Corey Minyard <[email protected]>

• References:
  • [PATCH] I2C Part 1 - Remove some redundancy from the i2c-core.c file
    • From: Corey Minyard <[email protected]>

• Prev by Date: Re: security/keys/key.c broken with defconfig
• Next by Date: Re: [patch] Real-Time Preemption, -RT-2.6.12-rc1-V0.7.41-07
• Previous by thread: [PATCH] I2C Part 1 - Remove some redundancy from the i2c-core.c file
• Next by thread: Re: [PATCH] I2C Part 1 - Remove some redundancy from the i2c-core.c file
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]