Re: memory leak in net/sched/ipt.c?

On Wed, 2005-03-23 at 07:55, Thomas Graf wrote:
> * jamal <[email protected]> 2005-03-23 07:40

> > Just a small correction to patchlet:
> > The second kfree should check for existence of t.
> 
> t is either valid or NULL so it's not a problem, unless you want
> to create janitor work of course. ;->

if t is null you still goto rtattr_failure
I have seen people put little comments of "kfree will work if you
pass it NULL" - are you saying such assumptions exist all over
net/sched? didnt understand the janitor part.

cheers,
jamal

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: memory leak in net/sched/ipt.c?
    • From: Jan Engelhardt <[email protected]>
  • Re: memory leak in net/sched/ipt.c?
    • From: Thomas Graf <[email protected]>

• References:
  • Re: memory leak in net/sched/ipt.c?
    • From: Herbert Xu <[email protected]>
  • Re: memory leak in net/sched/ipt.c?
    • From: jamal <[email protected]>
  • Re: memory leak in net/sched/ipt.c?
    • From: Thomas Graf <[email protected]>

• Prev by Date: Re: [6/9] [RFC] Steps to fixing the driver model locking
• Next by Date: Re: kernel bug: futex_wait hang
• Previous by thread: Re: memory leak in net/sched/ipt.c?
• Next by thread: Re: memory leak in net/sched/ipt.c?
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]