[RFC: 2.6 patch] drivers/net/wireless/airo.c: correct a wrong

if
Reply-To: 

The Coverity checker correctly noted that this condition can't ever be 
fulfilled.

Can someone understanding this code check whether my guess what this 
should have been was right?

Or should the if get completely dropped?

Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.12-rc1-mm1-full/drivers/net/wireless/airo.c.old	2005-03-22 21:41:37.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/net/wireless/airo.c	2005-03-22 21:42:01.000000000 +0100
@@ -3440,9 +3440,6 @@
 	/* Make sure we got something */
 	if (rxd.rdy && rxd.valid == 0) {
 		len = rxd.len + 12;
-		if (len < 12 && len > 2048)
-			goto badrx;
-
 		skb = dev_alloc_skb(len);
 		if (!skb) {
 			ai->stats.rx_dropped++;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFC: 2.6 patch] drivers/net/wireless/airo.c: correct a wrong
    • From: Jeff Garzik <[email protected]>

• Prev by Date: Re: [RFC: 2.6 patch] drivers/net/wireless/airo.c: correct a wrong
• Next by Date: help needed pls. scheduler(kernel 2.6) + hyperthreaded related questions?
• Previous by thread: ASYNC IO using RT Signals
• Next by thread: Re: [RFC: 2.6 patch] drivers/net/wireless/airo.c: correct a wrong
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]