Re: [PATCH] Hibernation: Document __save_processor_state() on x86-64

On Sunday, 30 of December 2007, Ingo Molnar wrote:
> 
> * Rafael J. Wysocki <[email protected]> wrote:
> 
> > From: Rafael J. Wysocki <[email protected]>
> > 
> > Document the fact that __save_processor_state() has to save all CPU 
> > registers referred to by the kernel in case a different kernel is used 
> > to load and restore a hibernation image containing it.
> 
> ok - so i guess i should drop this from x86.git:
> 
>  @@ -53,7 +53,6 @@ void __save_processor_state(struct saved
>          ctxt->cr2 = read_cr2();
>          ctxt->cr3 = read_cr3();
>          ctxt->cr4 = read_cr4();
>  -       ctxt->cr8 = read_cr8();
>   }
> 
> right?

Well, if cr8 is used for anything that matters, then yes.

> But i'm wondering - are we really ever resuming to a different  
> kernel version, for this to be an issue?

The boot kernel may be different from the kernel within the image, if that's
what you're asking for.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Hibernation: Document __save_processor_state() on x86-64
    • From: Ingo Molnar <[email protected]>

• References:
  • [PATCH] Hibernation: Document __save_processor_state() on x86-64
    • From: "Rafael J. Wysocki" <[email protected]>
  • Re: [PATCH] Hibernation: Document __save_processor_state() on x86-64
    • From: Ingo Molnar <[email protected]>

• Prev by Date: Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override
• Next by Date: Re: [PATCH] Option to disable AMD C1E (allows dynticks to work)
• Previous by thread: Re: [PATCH] Hibernation: Document __save_processor_state() on x86-64
• Next by thread: Re: [PATCH] Hibernation: Document __save_processor_state() on x86-64
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]