On Friday 28 December 2007, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
> > Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
>
> Acked-by: Sergei Shtylyov <[email protected]>
>
> > Index: b/drivers/ide/pci/piix.c
> > ===================================================================
> > --- a/drivers/ide/pci/piix.c
> > +++ b/drivers/ide/pci/piix.c
> > @@ -8,53 +8,8 @@
> > *
> > * May be copied or modified under the terms of the GNU General Public License
> > *
> > - * PIO mode setting function for Intel chipsets.
> > - * For use instead of BIOS settings.
> > + * Documentation:
> > *
> > - * 40-41
> > - * 42-43
> > - *
> > - * 41
> > - * 43
> > - *
> > - * | PIO 0 | c0 | 80 | 0 |
> > - * | PIO 2 | SW2 | d0 | 90 | 4 |
> > - * | PIO 3 | MW1 | e1 | a1 | 9 |
> > - * | PIO 4 | MW2 | e3 | a3 | b |
> > - *
> > - * sitre = word40 & 0x4000; primary
> > - * sitre = word42 & 0x4000; secondary
> > - *
> > - * 44 8421|8421 hdd|hdb
> > - *
> > - * 48 8421 hdd|hdc|hdb|hda udma enabled
> > - *
> > - * 0001 hda
> > - * 0010 hdb
> > - * 0100 hdc
> > - * 1000 hdd
> > - *
> > - * 4a 84|21 hdb|hda
> > - * 4b 84|21 hdd|hdc
> > - *
> > - * ata-33/82371AB
> > - * ata-33/82371EB
> > - * ata-33/82801AB ata-66/82801AA
> > - * 00|00 udma 0 00|00 reserved
> > - * 01|01 udma 1 01|01 udma 3
> > - * 10|10 udma 2 10|10 udma 4
> > - * 11|11 reserved 11|11 reserved
> > - *
> > - * 54 8421|8421 ata66 drive|ata66 enable
>
> You could have left te progarmming info intact...
Well, I thought about that but:
* It referenced ATA devices using hd[a-d] naming which while matches with
most of use cases is not 100% correct (piix driver can be modular etc).
* Right below there is a note about the official Intel documentation
(which is publically available).
* The piix.c code is self-documenting nowadays (in large parts thanks to
your efforts). :)
Thanks,
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
