Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements

On Thu, Dec 06, 2007 at 03:37:46PM +0100, Richard Knutsson wrote:
>
> Is it not an improvement to distinct booleans from actual values? Do you 
> use integers for ASCII characters too? It can also avoid some potential 
> bugs like the 'if (i == TRUE)'...
> What is wrong with 'size_t' (since it is unsigned, compared to (some) 
> 'int')?

I agree with Dave.  There are so many useful things that we can do
(and need to do) in IPsec that bool/size_t conversions just add
churn without adding much value.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [Patch] net/xfrm/xfrm_policy.c: Some small improvements
    • From: WANG Cong <[email protected]>
  • Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements
    • From: David Miller <[email protected]>
  • Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements
    • From: Richard Knutsson <[email protected]>

• Prev by Date: Re: [RFC] [PATCH] A clean approach to writeout throttling
• Next by Date: Re: [RFC PATCH 0/5] Union Mount: A Directory listing approach with lseek support
• Previous by thread: Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements
• Next by thread: Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]