Re: [PATCH] Reduce stack used by lib/hexdump.c

On Wed, 2007-12-05 at 18:18 -0800, Randy Dunlap wrote:
> Joe Perches wrote:
> > Maybe just eliminate the 16 or 32 byte width option and
> > force it to only 16 byte widths.
> Have you checked users (callers)?  I'm pretty sure that one of the
> callers wanted 32 and that's why it's there.

I did.  There is only 1 subsystem.  That's easy to change.

drivers/mtd/ubi/debug.c:  print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 1,
drivers/mtd/ubi/io.c:     print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 1,

Long lines in the log file are not too easy to read anyway.
Using 16 byte dumps per line instead of 32 isn't painful.

It gets rid of the allocation, reduces the argument count
and makes the kernel smaller.  I think it's all good.

Every current caller would have to change though.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Reduce stack used by lib/hexdump.c
    • From: Kyle Moffett <[email protected]>

• References:
  • [PATCH] Remove #define hex_asc from kernel.h, update lib/hexdump.c
    • From: Joe Perches <[email protected]>
  • Re: [PATCH] Remove #define hex_asc from kernel.h, update lib/hexdump.c
    • From: Randy Dunlap <[email protected]>
  • Re: [PATCH] Remove #define hex_asc from kernel.h, update lib/hexdump.c
    • From: Joe Perches <[email protected]>
  • Re: [PATCH] Remove #define hex_asc from kernel.h, update lib/hexdump.c
    • From: Randy Dunlap <[email protected]>
  • [PATCH] Reduce stack used by lib/hexdump.c
    • From: Joe Perches <[email protected]>
  • Re: [PATCH] Reduce stack used by lib/hexdump.c
    • From: Randy Dunlap <[email protected]>
  • Re: [PATCH] Reduce stack used by lib/hexdump.c
    • From: Jan Engelhardt <[email protected]>
  • Re: [PATCH] Reduce stack used by lib/hexdump.c
    • From: Joe Perches <[email protected]>
  • Re: [PATCH] Reduce stack used by lib/hexdump.c
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] Reduce stack used by lib/hexdump.c
    • From: Joe Perches <[email protected]>
  • Re: [PATCH] Reduce stack used by lib/hexdump.c
    • From: Randy Dunlap <[email protected]>

• Prev by Date: [patch-RFC 23/26] Prepare x86_64 for TIF_SYSCALL_TRACE async flag set in entry.S
• Next by Date: [patch-early-RFC 06/10] LTTng - instrumentation SH
• Previous by thread: Re: [PATCH] Reduce stack used by lib/hexdump.c
• Next by thread: Re: [PATCH] Reduce stack used by lib/hexdump.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]