Re: [PATCH] USB: option: Bind to the correct interface of the Huawei E220

On Fri, 30 Nov 2007 16:30:11 +0000, Jaime Velasco Juan <[email protected]> wrote:

> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> -	{ USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220) },
> -	{ USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220BIS) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220, 0xff, 0xff, 0xff) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220BIS, 0xff, 0xff, 0xff) },

Looks good to me, shorter than my patch, has no duplication, allows to
use the storage, looks like a winner. Unfortunately, it leaves ub for dead,
because ub cannot invoke the necessary initializer unless we move it to
libusual. But oh well, I'll think about it.

Took me this long to test because I had to ask kind people in England
to replug the modem.

Signed-off-by: Pete Zaitcev <[email protected]>

-- Pete
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] USB: option: Bind to the correct interface of the Huawei E220
    • From: Oliver Neukum <[email protected]>

• References:
  • Add the infamous Huawei E220 to option.c
    • From: Pete Zaitcev <[email protected]>
  • Re: Add the infamous Huawei E220 to option.c
    • From: Johann Wilhelm <[email protected]>
  • Re: Add the infamous Huawei E220 to option.c
    • From: Jaime Velasco Juan <[email protected]>
  • Re: Add the infamous Huawei E220 to option.c
    • From: Oliver Neukum <[email protected]>
  • [PATCH] USB: option: Bind to the correct interface of the Huawei E220
    • From: Jaime Velasco Juan <[email protected]>

• Prev by Date: [PATCH] UML - change sigcontext fields to match x86
• Next by Date: Re: [PATCH] x86_64: some whitespace cleanups in paging code
• Previous by thread: Re: [PATCH] USB: option: Bind to the correct interface of the Huawei E220
• Next by thread: Re: [PATCH] USB: option: Bind to the correct interface of the Huawei E220
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]