Re: [PATCH 1/3] fix setsid() for sub-namespace /sbin/init

On 11/26, Eric W. Biederman wrote:
>
> Oleg Nesterov <[email protected]> writes:
> 
> > This is different, perhaps we can keep this call. kernel_thread(kernel_init)
> > attaches /sbin/init to init_struct_pid. Nothing bad, and a "good" init should
> > do setsid() anyway. But who knows? Some special environment may expect that
> > getpgrp() != 0. Not that I really disagree on this issue though.
> 
> init starting with session == pgrp == 0 is historical linux behavior.  I consider
> the current 2.6 behavior a temporary aberation from the historical linux behavior.

Ah, OK.

> Plus once we do this the code will be easier to maintain because we have
> removed one obscure special case.

Yes indeed. So we can remove this special case code as soon as copy_process()
is changed.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/3] fix setsid() for sub-namespace /sbin/init
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH 1/3] fix setsid() for sub-namespace /sbin/init
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 1/3] fix setsid() for sub-namespace /sbin/init
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH 1/3] fix setsid() for sub-namespace /sbin/init
    • From: [email protected] (Eric W. Biederman)

• Prev by Date: Re: Avoid creating P2P prefetch window for expansion ROMs
• Next by Date: Re: Where is the interrupt going?
• Previous by thread: Re: [PATCH 1/3] fix setsid() for sub-namespace /sbin/init
• Next by thread: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]