Re: [PATCH 2/2] ide-scsi: use print_hex_dump from <linux/kernel.h>

Matthew Wilcox wrote:

On Mon, Nov 26, 2007 at 04:37:50PM +0800, rae l wrote:

I know this is different from the original hexdump in ide-scsi.c, I
just want to tell someone that there's a good implementation of
hexdump in kernel.h, and I think the default KERN_DEBUG and
print_hex_dump is more informative and has better output. However,
anyone want more precise control on debug message could make her/his
improvements with print_hex_dump.

using KERN_DEBUG is wrong -- this is part of a line, so you need to use
KERN_NONE or simply "".

s/KERN_NONE/KERN_CONT/ for continuation lines.

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 2/2] ide-scsi: use print_hex_dump from <linux/kernel.h>
    • From: Denis Cheng <[email protected]>
  • Re: [PATCH 2/2] ide-scsi: use print_hex_dump from <linux/kernel.h>
    • From: "rae l" <[email protected]>
  • Re: [PATCH 2/2] ide-scsi: use print_hex_dump from <linux/kernel.h>
    • From: Matthew Wilcox <[email protected]>

• Prev by Date: [PATCH] [REISERFS]: Complement va_start() with va_end().
• Next by Date: Reminder: Linux Storage and Filesystem Workshop
• Previous by thread: Re: [PATCH 2/2] ide-scsi: use print_hex_dump from <linux/kernel.h>
• Next by thread: Re: [PATCH 2/2] ide-scsi: use print_hex_dump from <linux/kernel.h>
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]