On Fri, 23 Nov 2007 02:58:55 +0100
Bartlomiej Zolnierkiewicz <[email protected]> wrote:
> On Friday 23 November 2007, Alan Cox wrote:
> > On Thu, 22 Nov 2007 16:48:53 -0800
> > [email protected] wrote:
> >
> > >
> > > I tried the hammer and the problem persists.
> >
> > See my earlier email - your driver registers the irq with IRQF_DISABLED
> > then never enables it.
>
> As already explained by Kyle IRQF_DISABLED shouldn't matter here.
>
> [ Nowadays IRQF_DISABLED only tells kernel/irq/handle.c::handle_IRQ_event()
> to not enable local interrupts before calling your IRQ handler.
>
> I've recently removed IRQF_DISABLED from IDE after noticing this. ]
Bartlomiej is of course correct. Thats what you get for replying late at
night in a hurry.
I'm not sure IDE can work without it because you need to lock out the
timer events (old IDE doesn't handle this at all on SMP though so it
wants fixing properly anyway).
Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
