On Mon, 2007-11-19 at 13:08 -0800, Andrew Morton wrote:
>
> > #else
> > -#define page_to_pfn __page_to_pfn
> > +#define page_to_pfn ((unsigned long)__page_to_pfn)
> > #define pfn_to_page __pfn_to_page
> > #endif /* CONFIG_OUT_OF_LINE_PFN_TO_PAGE */
>
> I'd have thought that __pfn_to_page() was the place to fix this: the
> lower-level point. Because someone might later start using
> __pfn_to_page()
> for something.
>
> Heaven knows why though - why does __pfn_to_page() even exist?
I think it's this stuff:
#ifdef CONFIG_OUT_OF_LINE_PFN_TO_PAGE
struct page *pfn_to_page(unsigned long pfn)
{
return __pfn_to_page(pfn);
}
unsigned long page_to_pfn(struct page *page)
{
return __page_to_pfn(page);
}
EXPORT_SYMBOL(pfn_to_page);
EXPORT_SYMBOL(page_to_pfn);
#endif /* CONFIG_OUT_OF_LINE_PFN_TO_PAGE */
Which comes from:
config OUT_OF_LINE_PFN_TO_PAGE
def_bool X86_64
depends on DISCONTIGMEM
and only on x86_64. Perhaps it can go away with the
discontig->sparsemem-vmemmap conversion.
-- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM
- From: Christoph Lameter <[email protected]>
- Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM
- From: Dave Hansen <[email protected]>
- Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM
- References:
- [RFC 5/7] LTTng instrumentation mm
- From: Mathieu Desnoyers <[email protected]>
- Re: [RFC 5/7] LTTng instrumentation mm
- From: Dave Hansen <[email protected]>
- Re: [RFC 5/7] LTTng instrumentation mm
- From: Mathieu Desnoyers <[email protected]>
- Re: [RFC 5/7] LTTng instrumentation mm
- From: Dave Hansen <[email protected]>
- Re: [RFC 5/7] LTTng instrumentation mm
- From: Mathieu Desnoyers <[email protected]>
- Re: [RFC 5/7] LTTng instrumentation mm
- From: Dave Hansen <[email protected]>
- Re: [RFC 5/7] LTTng instrumentation mm
- From: Mathieu Desnoyers <[email protected]>
- Re: [RFC 5/7] LTTng instrumentation mm
- From: Dave Hansen <[email protected]>
- [PATCH] Cast __page_to_pfn to unsigned long in CONFIG_SPARSEMEM
- From: Mathieu Desnoyers <[email protected]>
- Re: [PATCH] Cast __page_to_pfn to unsigned long in CONFIG_SPARSEMEM
- From: Dave Hansen <[email protected]>
- Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM
- From: Mathieu Desnoyers <[email protected]>
- Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM
- From: Andrew Morton <[email protected]>
- [RFC 5/7] LTTng instrumentation mm
- Prev by Date: Re: [Patch] mm/sparse.c: Check the return value of sparse_index_alloc().
- Next by Date: Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM
- Previous by thread: Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM
- Next by thread: Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM
- Index(es):
 |