On 2007-10-23 03:47:48 (+0200), Roel Kluin <[email protected]> wrote: > I think we should keep the lmc_tracing. Use this patch instead. > > -- > Several returns before unlocking in lmc_ioctl > > Signed-off-by: Roel Kluin <[email protected]> > --- > diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c > index 5ea8772..64eb578 100644 <snip> > @@ -229,9 +234,10 @@ int lmc_ioctl (struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/ > sc->lmc_xinfo.Magic1 = 0xDEADBEEF; > > if (copy_to_user(ifr->ifr_data, &sc->lmc_xinfo, > - sizeof (struct lmc_xinfo))) > - return -EFAULT; > - ret = 0; > + sizeof(struct lmc_xinfo))) { > + ret = -EFAULT; > + else > + ret = 0; I think you have an extra curly brace there. It breaks compile on my system. Kristof
Attachment:
pgpOfWjqScEQC.pgp
Description: PGP signature
- Follow-Ups:
- Re: [PATCH] several returns before unlocking in lmc_ioctl
- From: Roel Kluin <[email protected]>
- Re: [PATCH] several returns before unlocking in lmc_ioctl
- References:
- [PATCH] several returns before unlocking in lmc_ioctl
- From: Roel Kluin <[email protected]>
- Re: [PATCH] several returns before unlocking in lmc_ioctl
- From: Roel Kluin <[email protected]>
- [PATCH] several returns before unlocking in lmc_ioctl
- Prev by Date: Re: [PATCH 1/1] Blackfin EMAC driver: Fix Ethernet communication bug (dupliated and lost packets)
- Next by Date: Re: [patch 07/10] SLUB: Avoid referencing kmem_cache structure in __slab_alloc
- Previous by thread: Re: [PATCH] several returns before unlocking in lmc_ioctl
- Next by thread: Re: [PATCH] several returns before unlocking in lmc_ioctl
- Index(es):
 |