Re: [PATCH 3/4] VFS: factor out three helpers for FIBMAP/FIONBIO/FIOASYNC file ioctls

> +static int __ioctl_fibmap(struct file *filp, int __user *p)

I'd say kill the __ prefix for all the functions you're adding.

> +static int __ioctl_fionbio(struct file *filp, unsigned long arg)

> +static int __ioctl_fioasync(unsigned int fd, struct file *filp,
> +			    unsigned long arg)

For these two I'd add a

	void __user *argp = (void __user *)arg;

in the caller and then just pass argp down.  That way we have the cast in
one place.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 3/4] VFS: factor out three helpers for FIBMAP/FIONBIO/FIOASYNC file ioctls
    • From: Erez Zadok <[email protected]>

• References:
  • [PATCH] 0/4 fs/ioctl.c coding style, rename vfs_ioctl/do_ioctl, refactoring (take 2)
    • From: Erez Zadok <[email protected]>
  • [PATCH 3/4] VFS: factor out three helpers for FIBMAP/FIONBIO/FIOASYNC file ioctls
    • From: Erez Zadok <[email protected]>

• Prev by Date: Re: [PATCH 2/4] VFS: swap do_ioctl and vfs_ioctl names
• Next by Date: Re: sata_nv and dynamically changing DMA mask?
• Previous by thread: [PATCH 3/4] VFS: factor out three helpers for FIBMAP/FIONBIO/FIOASYNC file ioctls
• Next by thread: Re: [PATCH 3/4] VFS: factor out three helpers for FIBMAP/FIONBIO/FIOASYNC file ioctls
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]