Re: [PATCH] pidns: Limit kill -1 and cap_set_all

Kirill Korotaev <[email protected]> writes:

> I dislike this patch:
> it's not scalable/efficient to travers all the tasks
> while we know the pid namespace we care about.

Well the unix way is to implement it simple and stupid and then to
optimize, where needed.  We don't currently have a per pid namespace
list of processes or tasks.

This is a trivial bug fix patch, and I wanted the review to be as
simple as possible.

I don't expect people are doing kill -1 all that frequently as it is a
bit rude.

I have no problem doing find_ge_pid and then looking in the hash table
like we do in /proc.  It likely will have fewer conflicts, but that
is a bit harder to review, and is actually more code.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] proc: Fix proc_kill_inodes to kill dentries on all proc superblocks
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH] proc: Fix proc_kill_inodes to kill dentries on all proc superblocks
    • From: Linus Torvalds <[email protected]>
  • [PATCH] proc: Simplify and correct proc_flush_task
    • From: [email protected] (Eric W. Biederman)
  • [PATCH] pidns: Limit kill -1 and cap_set_all
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH] pidns: Limit kill -1 and cap_set_all
    • From: Kirill Korotaev <[email protected]>

• Prev by Date: Re: [PATCH] pidns: Limit kill -1 and cap_set_all
• Next by Date: Re: [Devel] [PATCH] pidns: Place under CONFIG_EXPERIMENTAL (take 2)
• Previous by thread: Re: [PATCH] pidns: Limit kill -1 and cap_set_all
• Next by thread: Re: [PATCH] pidns: Limit kill -1 and cap_set_all
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]