Re: [PATCH] FRV: Permit the memory to be located elsewhere in NOMMU mode

On Mon, 29 Oct 2007, David Howells wrote:
>  
> -__page_offset = 0xc0000000;		/* start of area covered by struct pages */
> +/* start of area covered by struct pages */
> +#if defined(CONFIG_UCPAGE_OFFSET_20000000)
> +__page_offset = 0x20000000;
> +#elif defined(CONFIG_UCPAGE_OFFSET_40000000)
> +__page_offset = 0x40000000;
...

Please don't do these kinds of things in the source code.

Do them in the Kconfig language where it belongs, and where it makes much 
more sense.

See, for example, arch/x86/Kconfig.i386:

	config PAGE_OFFSET
	        hex
	        default 0xB0000000 if VMSPLIT_3G_OPT
	        default 0x80000000 if VMSPLIT_2G
	        default 0x78000000 if VMSPLIT_2G_OPT
	        default 0x40000000 if VMSPLIT_1G
	        default 0xC0000000

Notice? Even the syntax is much cleaner!

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] FRV: Permit the memory to be located elsewhere in NOMMU mode
    • From: David Howells <[email protected]>

• Prev by Date: [PATCH] Report usage in CFS cgroup
• Next by Date: Re: [PATCH v4 1/2] SCSI: Asynchronous event notification infrastructure
• Previous by thread: [PATCH] FRV: Permit the memory to be located elsewhere in NOMMU mode
• Next by thread: Re: [PATCH] FRV: Permit the memory to be located elsewhere in NOMMU mode
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]