On Tue, 16 Oct 2007 14:33:38 -0700 Nish Aravamudan wrote:
> On 10/16/07, Randy Dunlap <[email protected]> wrote:
> > 2.6.23-git7, using SLAB (not SLUB) [config attached]:
> >
> > # modprobe clip
> > # rmmod clip
> > # modprobe clip
> >
> > results in panic:
> >
> > kmem_cache_create: duplicate cache clip_arp_cache
> >
> > Call Trace:
> > [<ffffffff8028c682>] kmem_cache_create+0x3bf/0x3fd
> > [<ffffffff8046ba1d>] neigh_table_init_no_netlink+0x6c/0x242
> > [<ffffffff8800a010>] :clip:atm_clip_init+0x10/0x8a
> > [<ffffffff80258ba4>] sys_init_module+0x146c/0x15cd
> > [<ffffffff8046be0a>] neigh_lookup+0x0/0xd5
> > [<ffffffff8020ef44>] syscall_trace_enter+0x95/0x99
> > [<ffffffff8020beec>] tracesys+0xdc/0xe1
> >
> > Kernel panic - not syncing: kmem_cache_create(): failed to create slab `clip_arp_cache'
>
> >From a quick read through the code, looks like
> net/core/neighbour.c:neigh_table_clear() needs a kmem_cache_destroy()?
>
> I only see three callers of neight_table_clear() and they all seem to
> be in exit routines, so that should be safe?
Hi Nish,
Maybe. I can't tell without knowing the code better.
[make that patch, test it; test patch is below]
Well, it survives light testing (boot/init and a tarball download),
but I don't know how safe it is.
---
From: Randy Dunlap <[email protected]>
net/atm/clip.c crashes the kernel if it (module) is loaded, removed,
and then loaded again. Its exit call to neigh_table_clear()
should destroy the cache after freeing it.
Signed-off-by: Randy Dunlap <[email protected]>
---
net/core/neighbour.c | 3 +++
1 file changed, 3 insertions(+)
--- linux-2.6.23-git7.orig/net/core/neighbour.c
+++ linux-2.6.23-git7/net/core/neighbour.c
@@ -1436,6 +1436,9 @@ int neigh_table_clear(struct neigh_table
free_percpu(tbl->stats);
tbl->stats = NULL;
+ kmem_cache_destroy(tbl->kmem_cachep);
+ tbl->kmem_cachep = NULL;
+
return 0;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
