On Tue, Oct 16, 2007 at 09:54:42PM -0400, Mark Lord wrote:
> if (rc)
> goto err_out_free_ctrl_slot;
> - }
> + } else if (pciehp_force)
> + pciehp_enable_slot(t_slot);
>
I find the construct if () { ... } else ...; to be a bit jarring. How
about adding the extra braces?
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- Re: PCIe Hotplug: NFG unless I boot with card already inserted.
- From: Mark Lord <[email protected]>
- Re: PCIe Hotplug: NFG unless I boot with card already inserted.
- From: Mark Lord <[email protected]>
- Re: PCIe Hotplug: NFG unless I boot with card already inserted.
- From: Mark Lord <[email protected]>
- Re: PCIe Hotplug: NFG unless I boot with card already inserted.
- From: Kristen Carlson Accardi <[email protected]>
- Re: PCIe Hotplug: NFG unless I boot with card already inserted.
- From: Mark Lord <[email protected]>
- Re: [Pcihpd-discuss] PCIe Hotplug: NFG unless I boot with card already inserted.
- From: Greg KH <[email protected]>
- [PATCH] Fix PCIe hotplug for Dell notebook ExpressCard slots
- From: Mark Lord <[email protected]>
- [PATCH 0/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)
- From: Mark Lord <[email protected]>
- [PATCH 1/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)
- From: Mark Lord <[email protected]>
- [PATCH 2/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)
- From: Mark Lord <[email protected]>
- Re: PCIe Hotplug: NFG unless I boot with card already inserted.
- Prev by Date: Re: [PATCH 2/3] dma: redefine dma_flags_set/get_*() for sn-ia64
- Next by Date: Re: [PATCH 3/3] document dma_flags_set/get_*()
- Previous by thread: Re: [PATCH 4/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)
- Next by thread: Re: [Pcihpd-discuss] [PATCH 2/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)
- Index(es):
 |