[PATCH] hptiop: avoid buffer overflow when returning sense data

avoid buffer overflow when returning sense data.

Signed-off-by: HighPoint Linux Team <[email protected]>
---

diff --git a/drivers/scsi/hptiop.c b/drivers/scsi/hptiop.c
index 8b384fa..d32a4a9 100644
--- a/drivers/scsi/hptiop.c
+++ b/drivers/scsi/hptiop.c
@@ -375,8 +375,9 @@ static void hptiop_host_request_callback
 		scp->result = SAM_STAT_CHECK_CONDITION;
 		memset(&scp->sense_buffer,
 				0, sizeof(scp->sense_buffer));
-		memcpy(&scp->sense_buffer,
-			&req->sg_list, le32_to_cpu(req->dataxfer_length));
+		memcpy(&scp->sense_buffer, &req->sg_list,
+				min(sizeof(scp->sense_buffer),
+					le32_to_cpu(req->dataxfer_length)));
 		break;
 
 	default:

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] hptiop: avoid buffer overflow when returning sense data
    • From: HighPoint Linux Team <[email protected]>
  • Re: [PATCH] hptiop: avoid buffer overflow when returning sense data
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH] hptiop: avoid buffer overflow when returning sense data
• Next by Date: Re: apm system does not power off anymore
• Previous by thread: [PATCH][resend] param_sysfs_builtin memchr argument fix
• Next by thread: Re: [PATCH] hptiop: avoid buffer overflow when returning sense data
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]