Re: [patch 8/9] compat_ioctl: call disk->fops->compat_ioctl without BKL

On Sat, Oct 06, 2007 at 08:19:10PM +0200, Arnd Bergmann wrote:
> Normally, all compat_ioctl operations are called without the BKL, the
> block device operations are an exception to this rule.
> 
> Make this work the same as the other handlers.
> 
> Signed-off-by: Arnd Bergmann <[email protected]>
> 
> ---
> It would be good to find out whether it has been using the BKL
> on purpose or by accident, before this patch gets applied.

Leave it alone, for now - I'm rebasing my series on top of your 1--7
and it will both makes ->ioctl() and ->compat_ioctl() called unlocked
and switches ->compat_ioctl() to passing bdev instead of struct file
(->unlocked_ioctl() simply dies).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 8/9] compat_ioctl: call disk->fops->compat_ioctl without BKL
    • From: Arnd Bergmann <[email protected]>

• References:
  • [patch 0/9] compat_ioctl: introduce block/compat_ioctl.c
    • From: Arnd Bergmann <[email protected]>
  • [patch 8/9] compat_ioctl: call disk->fops->compat_ioctl without BKL
    • From: Arnd Bergmann <[email protected]>

• Prev by Date: Re: A bit of kconfig rewrite (Re: [PATCH] 9p: fix compile error if !CONFIG_SYSCTL)
• Next by Date: Re: [patch 9/9] compat_ioctl: fix compat_fd_ioctl pointer access
• Previous by thread: [patch 8/9] compat_ioctl: call disk->fops->compat_ioctl without BKL
• Next by thread: Re: [patch 8/9] compat_ioctl: call disk->fops->compat_ioctl without BKL
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]