[PATCH 04/51] [GFS2] GFS2 not checking pointer on create when running under nfsd

From: Steve French <[email protected]>

When looking at an unrelated problem, I noticed that nfsd does not
set nameidata pointer on create (ie nd is NULL).  This should
cause an oops in some cases in which when NFSd is mounted over GFS2.

Signed-off-by: Steve French <[email protected]>
Signed-off-by: Steven Whitehouse <[email protected]>

diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c
index 911c115..5b8b994 100644
--- a/fs/gfs2/ops_inode.c
+++ b/fs/gfs2/ops_inode.c
@@ -69,7 +69,7 @@ static int gfs2_create(struct inode *dir, struct dentry *dentry,
 			mark_inode_dirty(inode);
 			break;
 		} else if (PTR_ERR(inode) != -EEXIST ||
-			   (nd->intent.open.flags & O_EXCL)) {
+			   (nd && (nd->intent.open.flags & O_EXCL))) {
 			gfs2_holder_uninit(ghs);
 			return PTR_ERR(inode);
 		}
-- 
1.5.1.2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH 05/51] [GFS2] Fix an oops in glock dumping
    • From: [email protected]

• References:
  • [GFS2/DLM] Pre-pull patch posting
    • From: [email protected]
  • [PATCH 01/51] [GFS2] Fix two races relating to glock callbacks
    • From: [email protected]
  • [PATCH 02/51] [GFS2] Fix calculation of demote state
    • From: [email protected]
  • [PATCH 03/51] [GFS2] Clean up duplicate includes in fs/gfs2/
    • From: [email protected]

• Prev by Date: [PATCH 26/51] [DLM] Fix lowcomms socket closing
• Next by Date: [PATCH 27/51] [GFS2] Wendy's dump lockname in hex & fix glock dump
• Previous by thread: [PATCH 03/51] [GFS2] Clean up duplicate includes in fs/gfs2/
• Next by thread: [PATCH 05/51] [GFS2] Fix an oops in glock dumping
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]