Re: [PATCH 4/5] writeback: remove pages_skipped accounting in __block_write_full_page()

On Wed, Oct 03, 2007 at 09:43:33AM +0800, Fengguang Wu wrote:
> On Wed, Oct 03, 2007 at 07:55:18AM +1000, David Chinner wrote:
> > > 
> > > do not quite agree with each other. The page writeback should be skipped for
> > > 'locked buffer', but here it is 'clean buffer'!
> > 
> > Ok, so that means we need an equivalent fix in xfs_start_page_writeback()
> > as it will skip pages with clean buffers just like this. Something like
> > this (untested)?
> 
> Sure OK - as long as it is 'no write because of clean buffer'.

Yes, that's the case here.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH 4/5] writeback: remove pages_skipped accounting in __block_write_full_page()
    • From: David Chinner <[email protected]>

• Prev by Date: Re: RTC wakealarm write-only, still has 644 permissions
• Next by Date: Re: [PATCH] Document x86-64 iommu kernel parameters
• Previous by thread: Re: [PATCH 4/5] writeback: remove pages_skipped accounting in __block_write_full_page()
• Next by thread: [PATCH 5/5] writeback: introduce writeback_control.more_io to indicate more io
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]