On Fri, 28 Sep 2007 20:56:30 +0000 (UTC) Maarten Bressers wrote:
> This (trivial) patch fixes two compiler warnings for 2.6.23-rc8 on x86_64,
> use of deprecated function pci_find_device() and a section mismatch.
> Build log and .config file included.
>
> Signed-off by: Maarten Bressers <[email protected]>
Please include the text from section mismatch warnings in the patch
description.
> diff --git a/arch/x86_64/kernel/smpboot.c b/arch/x86_64/kernel/smpboot.c
> index 32f5078..7c872df 100644
> --- a/arch/x86_64/kernel/smpboot.c
> +++ b/arch/x86_64/kernel/smpboot.c
> @@ -532,7 +532,7 @@ struct create_idle {
> int cpu;
> };
>
> -void do_fork_idle(struct work_struct *work)
> +static void __cpuinit do_fork_idle(struct work_struct *work)
> {
> struct create_idle *c_idle =
> container_of(work, struct create_idle, work);
> diff --git a/drivers/pci/search.c b/drivers/pci/search.c
> index c6e79d0..0eb7e9e 100644
> --- a/drivers/pci/search.c
> +++ b/drivers/pci/search.c
> @@ -96,7 +96,7 @@ pci_find_slot(unsigned int bus, unsigned int devfn)
> {
> struct pci_dev *dev = NULL;
>
> - while ((dev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
> + while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
> if (dev->bus->number == bus && dev->devfn == devfn)
> return dev;
> }
> @@ -434,8 +434,6 @@ int pci_dev_present(const struct pci_device_id *ids)
> EXPORT_SYMBOL(pci_dev_present);
> EXPORT_SYMBOL(pci_find_present);
>
> -EXPORT_SYMBOL(pci_find_device);
> -EXPORT_SYMBOL(pci_find_slot);
There are still about 30 and 14 respetively users of pci_find_devic()
and pci_find_slot() in 2.6.23-rc8. Will you be fixing them?
> /* For boot time work */
> EXPORT_SYMBOL(pci_find_bus);
> EXPORT_SYMBOL(pci_find_next_bus);
---
~Randy
Phaedrus says that Quality is about caring.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
