[patch] fix sys_mknodat breakage from r/o bind mounts

From: Miklos Szeredi <[email protected]>

mknod("foo", 0644) returns EINVAL, even though it should succeed.

The responsible patch is this:

r-o-bind-mounts-sys_mknodat-elevate-write-count-for-vfs_mknod-create.patch

Signed-off-by: Miklos Szeredi <[email protected]>
---

Index: linux/fs/namei.c
===================================================================
--- linux.orig/fs/namei.c	2007-09-26 00:36:15.000000000 +0200
+++ linux/fs/namei.c	2007-09-26 00:51:19.000000000 +0200
@@ -1984,7 +1984,7 @@ asmlinkage long sys_mknodat(int dfd, con
 		goto out_dput;
 	}
 	if (!S_ISREG(mode)  && !S_ISCHR(mode)  && !S_ISBLK(mode) &&
-	    !S_ISFIFO(mode) && !S_ISSOCK(mode) && mode != 0) {
+	    !S_ISFIFO(mode) && !S_ISSOCK(mode) && (mode & S_IFMT) != 0) {
 		error = -EINVAL;
 		goto out_dput;
 	}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch] fix sys_mknodat breakage from r/o bind mounts
    • From: Christoph Hellwig <[email protected]>
  • Re: [patch] fix sys_mknodat breakage from r/o bind mounts
    • From: Dave Hansen <[email protected]>

• Prev by Date: Re: subsystem_unregister() breakage in -mm
• Next by Date: Re: subsystem_unregister() breakage in -mm
• Previous by thread: subsystem_unregister() breakage in -mm
• Next by thread: Re: [patch] fix sys_mknodat breakage from r/o bind mounts
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]