On Mon, 24 Sep 2007 08:22:31 +0200, Jan Engelhardt said: > > On Sep 24 2007 01:35, [email protected] wrote: > >On Sun, 23 Sep 2007 00:03:49 +0400, Alexey Dobriyan said: > > > >> -static inline void *kcalloc(size_t n, size_t size, gfp_t flags) > >> -{ > >> - if (n != 0 && size > ULONG_MAX / n) > >> - return NULL; > >> - return __kmalloc(n * size, flags | __GFP_ZERO); > >> -} > >> +void *kcalloc(size_t n, size_t size, gfp_t flags); > > > >NAK. > > > >This busticates some pretty subtle code in mm/slab.c that uses > >uses __builtin_return_address() for debugging - if you do this, then > >the "calling function" gets listed as "kcalloc()" rather than the much more > >useful "function that called kcalloc()" (which is what you care about). > > > >(I remember going around and around multiple times getting those stupid > >inlines set up right, so that feature actually did something useful, otherwise > >kcalloc and kzalloc didn't report where they were called from). > > Since 'inline' is only a hint , should not it be __always_inline, > so that __builtin_return_address() always works? At the time I was trying to fix that, saying "inline" actually forced it to be so. Probably need to go re-check that, since there's been about forty-leven different "tweak the semantics of inline" since then....
Attachment:
pgpM3a1O51yIw.pgp
Description: PGP signature
- References:
- [PATCH] Uninline kcalloc()
- From: Alexey Dobriyan <[email protected]>
- Re: [PATCH] Uninline kcalloc()
- From: [email protected]
- Re: [PATCH] Uninline kcalloc()
- From: Jan Engelhardt <[email protected]>
- [PATCH] Uninline kcalloc()
- Prev by Date: [PATCH] Move kasprintf.o to obj-y
- Next by Date: Re: 2.6.23-rc6-mm1 -- mkfs stuck in 'D'
- Previous by thread: Re: [PATCH] Uninline kcalloc()
- Next by thread: Re: [PATCH] Uninline kcalloc()
- Index(es):
 |