Re: [PATCH] ppp_mppe: Don't put InterimKey on the stack

On Fri, Sep 21, 2007 at 04:08:09PM +0200, Michal Schmidt wrote:
> Hello,
> 
> The interrupt stack can be in the __START_KERNEL_map region in which
> virt_to_page will not work. This caused ppp_mppe to crash on CentOS 5 on x86_64
> (http://bugs.centos.org/view.php?id=2076).
> 
> The fix is to avoid copying the interim key. We can simply use it in its
> original place, which is kmalloc'd.

Needs a Signed-off-by: line, but otherwise, looks good, and even saves
some stack space.  Thanks for tracking this down.

-Matt

-- 
Matt Domsch
Linux Technology Strategist, Dell Office of the CTO
linux.dell.com & www.dell.com/linux
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] ppp_mppe: Don't put InterimKey on the stack
    • From: Michal Schmidt <[email protected]>

• References:
  • [PATCH] ppp_mppe: Don't put InterimKey on the stack
    • From: Michal Schmidt <[email protected]>

• Prev by Date: [PATCH 00/22] Introduce credential record
• Next by Date: Re: [Minor patch] Reduce __print_symbol/sprint_symbol stack usage.
• Previous by thread: [PATCH] ppp_mppe: Don't put InterimKey on the stack
• Next by thread: Re: [PATCH] ppp_mppe: Don't put InterimKey on the stack
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]