Re: [PATCH] Add a refcount check in dput()

On 9/15/07, Andrew Morton <[email protected]> wrote:
> >
> > +     BUG_ON(!atomic_read(&dentry->d_count));
> >  repeat:
> >       if (atomic_read(&dentry->d_count) == 1)
> >               might_sleep();
>
> eek, much too aggressive.

How about the equivalent BUG_ON() in dget()? I figure that they ought
to both be of the same strictness.

Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Add a refcount check in dput()
    • From: Andrew Morton <[email protected]>

• References:
  • [PATCH] Add a refcount check in dput()
    • From: [email protected] (Paul Menage)
  • Re: [PATCH] Add a refcount check in dput()
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH 001/104] KVM: Fix *nopage() in kvm_main.c
• Next by Date: Re: task containersv11 kernel BUG at include/linux/dcache.h:323
• Previous by thread: Re: [PATCH] Add a refcount check in dput()
• Next by thread: Re: [PATCH] Add a refcount check in dput()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]