Re: [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api

Alan Cox napsal(a):
> ase, 0x80);
>> remove also the hwbase var.
>>
>>> +	rebase = pci_iomap(pdev, 0, 0x80);
>>>   	t = readl(rebase + CNTRL_REG_OFFSET);
> 
> Switch to ioread* if you are using the iomap interface. Its not a trivial

Why, if you know it's surely a mem region (and thus you rely on it and do
ioremap)? There are many places in the kernel, where this approach is used, e.g.
libata piix.

> conversion and its slower and bulkier - the original ioremap was much
> better

at least get rid of the reading the hwbase address from pci conf space, use
pci_resource_start instead.

-- 
Jiri Slaby ([email protected])
Faculty of Informatics, Masaryk University
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api
    • From: Alan Cox <[email protected]>

• References:
  • [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api
    • From: Scott Thompson <[email protected]>
  • Re: [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api
    • From: "Jiri Slaby" <[email protected]>
  • Re: [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api
    • From: Alan Cox <[email protected]>

• Prev by Date: [PATCH] fix undefined reference to device_power_up/resume
• Next by Date: Re: [PATCH] sigqueue_free: fix the race with collect_signal()
• Previous by thread: Re: [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api
• Next by thread: Re: [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]