Re: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r

On Thu, 23 Aug 2007, Segher Boessenkool wrote:
> 
> This simply isn't true.  The compiler *can* combine asm stuff:

Please Segher, just shut up.

The combining, which I've mentioned *multiple*times* is

	if (atomic_read(&x) <= 1)

and dammit, if that doesn't result in a *single* instruction, the code 
generation is pure and utter crap.

It should result in

	cmpl $1,offset(reg)

and nothing else. And there is no way in hell you are doing that with 
"atomic_read()" being inline asm.

So can you now just go away?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • RE: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
    • From: "David Schwartz" <[email protected]>

• References:
  • [PATCH 0/23] make atomic_read() and atomic_set() behavior consistent across all architectures
    • From: Chris Snook <[email protected]>
  • [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
    • From: Chris Snook <[email protected]>
  • Re: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
    • From: Hirokazu Takata <[email protected]>
  • Re: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
    • From: Hirokazu Takata <[email protected]>
  • Re: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
    • From: Chris Snook <[email protected]>
  • Re: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
    • From: Segher Boessenkool <[email protected]>
  • Re: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
    • From: Segher Boessenkool <[email protected]>

• Prev by Date: Re: gettimeofday() jumping into the future
• Next by Date: Re: Firewire lockup on 2.6.22.3 in SMP but not UP, old drivers
• Previous by thread: Re: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
• Next by thread: RE: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]