On sabato 18 agosto 2007, Satyam Sharma wrote: > On Fri, 17 Aug 2007, Jeff Dike wrote: > > Style fixes in hostfs. > > @@ -328,17 +326,17 @@ int hostfs_readdir(struct file *file, vo > > [...] > > - if(error) break; > > + if (error) break; > > if (error) > break; > > > @@ -522,28 +523,28 @@ static int init_inode(struct inode *inod > > [...] > > else type = OS_TYPE_DIR; > > I wonder what's the generally accepted / followed coding style for this, > actually. Personally I'd prefer: > > else > type = OS_TYPE_DIR; I strongly agree with this style; beyond style itself, one strong reason is that joining statements hinder singlestepping through function code (it's easy to run gdb on UML, and anyway kgdb exists). Bye -- "Doh!" (cit.), I've made another mistake! Paolo Giarrusso, aka Blaisorblade Linux registered user n. 292729 http://www.user-mode-linux.org/~blaisorblade
Attachment:
signature.asc
Description: This is a digitally signed message part.
- Follow-Ups:
- Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style
- From: Jeff Dike <[email protected]>
- Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style
- References:
- [PATCH 6/6] UML - Fix hostfs style
- From: Jeff Dike <[email protected]>
- Re: [PATCH 6/6] UML - Fix hostfs style
- From: Satyam Sharma <[email protected]>
- [PATCH 6/6] UML - Fix hostfs style
- Prev by Date: Re: [Ecryptfs-devel] [PATCH] eCryptfs: fix possible fault in ecryptfs_sync_page
- Next by Date: Re: nf_conntrack_ipv4 must be loaded explicitly
- Previous by thread: Re: [PATCH 6/6] UML - Fix hostfs style
- Next by thread: Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style
- Index(es):
 |