Re: [2.6 patch] w1_remove_master_device(): fix check-after-use

Hi Adrian.

On Tue, Aug 14, 2007 at 11:22:48PM +0200, Adrian Bunk ([email protected]) wrote:
> The Coverity checker spotted that we'd have already oops'ed if "dev"
> was NULL.

This is wrong.
Although dev can not be null there there is no way it will crash.
The right paranoidal solution is to setup new pointer and make it equal
to the found device and check if it is NULL or not out of the loop.
I will cook up a patch tomorrow, thanks for pointing to this issue.

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [2.6 patch] w1_remove_master_device(): fix check-after-use
    • From: Adrian Bunk <[email protected]>

• Prev by Date: Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
• Next by Date: Re: [2.6 patch] remove Documentation/networking/net-modules.txt
• Previous by thread: [2.6 patch] w1_remove_master_device(): fix check-after-use
• Next by thread: [2.6 patch] net/8021q/vlanproc.c: fix check-after-use
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]