Re: [PATCH] Fix triplefault on x86-64 bootup

On Sun, 12 Aug 2007, Linus Torvalds wrote:
> 
> Hmm. Patch looks ok, I just wonder what started triggering this for you?

Oh. It's the "Make patching more robust" commit.

"Robust" my ass.

We used to just copy the replacement in one go (works fine, since it just 
overwrote the two first bytes), and then "nop_out()" the rest (works fine, 
since it didn't matter for memcpy).

That whole commit looks a bit dubious. It also adds a 254-byte stack 
usage (anything actually even close to that big?). Gaah.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Fix triplefault on x86-64 bootup
    • From: Andi Kleen <[email protected]>

• References:
  • [PATCH] Fix triplefault on x86-64 bootup
    • From: Petr Vandrovec <[email protected]>
  • Re: [PATCH] Fix triplefault on x86-64 bootup
    • From: Linus Torvalds <[email protected]>

• Prev by Date: Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()
• Next by Date: [PATCH] drivers/md/dm-crypt.c: potential memleak fix
• Previous by thread: Re: [PATCH] Fix triplefault on x86-64 bootup
• Next by thread: Re: [PATCH] Fix triplefault on x86-64 bootup
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]