Re: [RFC][PATCH 3/5] pagemap: remove open-coded sizeof(unsigned long)

On Tue, 2007-08-07 at 18:40 -0500, Matt Mackall wrote:
> On Tue, Aug 07, 2007 at 03:33:02PM -0700, Dave Hansen wrote:
> > +#define PAGEMAP_ENTRY_SIZE_BYTES sizeof(unsigned long)
> > +
> >  static int add_to_pagemap(unsigned long addr, unsigned long pfn,
> >  			  struct pagemapread *pm)
> >  {
> >  	__put_user(pfn, pm->out);
> >  	pm->out++;
> > -	pm->pos += sizeof(unsigned long);
> > -	pm->count -= sizeof(unsigned long);
> > -	pm->next = addr + PAGE_SIZE;
> > +	pm->pos += PAGEMAP_ENTRY_SIZE_BYTES;
> > +	pm->count -= PAGEMAP_ENTRY_SIZE_BYTES;
> 
> I think deleting ->next is a little premature here?

It is.  I'll fix that up.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFC][PATCH 3/5] pagemap: remove open-coded sizeof(unsigned long)
    • From: Matt Mackall <[email protected]>

• References:
  • [RFC][PATCH 1/5] pagemap: remove file header
    • From: Dave Hansen <[email protected]>
  • [RFC][PATCH 3/5] pagemap: remove open-coded sizeof(unsigned long)
    • From: Dave Hansen <[email protected]>
  • Re: [RFC][PATCH 3/5] pagemap: remove open-coded sizeof(unsigned long)
    • From: Matt Mackall <[email protected]>

• Prev by Date: Re: [PATCH] powerpc: Use linux/elfcore-compat.h
• Next by Date: Re: refcounting problems with ibm_acpi but acpi=off
• Previous by thread: Re: [RFC][PATCH 3/5] pagemap: remove open-coded sizeof(unsigned long)
• Next by thread: Re: [RFC][PATCH 3/5] pagemap: remove open-coded sizeof(unsigned long)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]