Re: [PATCH] Off-by-one in /sys/module/*/refcnt

Kay Sievers wrote:
>> @@ -785,7 +785,7 @@ static ssize_t show_refcnt(struct module_attribute *mattr,
>>                            struct module *mod, char *buffer)
>>  {
>>         /* sysfs holds a reference */
>> -       return sprintf(buffer, "%u\n", module_refcount(mod)-1);
>> +       return sprintf(buffer, "%u\n", module_refcount(mod));
>>  }
> 
> It's likely caused by sysfs core changes, that opened attributes are
> no longer coupled to the refcount of modules. They used to take a
> reference.
> 
> The "holds a reference" comment should be removed along with your fix.
> Adding Tejun, to confirm this.

Yeap, that's correct.  Opening a sysfs node doesn't hold the module anymore.

Thanks.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH v2] Off-by-one in /sys/module/*/refcnt
    • From: Alexey Dobriyan <[email protected]>

• References:
  • [PATCH] Off-by-one in /sys/module/*/refcnt
    • From: Alexey Dobriyan <[email protected]>
  • Re: [PATCH] Off-by-one in /sys/module/*/refcnt
    • From: "Kay Sievers" <[email protected]>

• Prev by Date: Re: Disk spin down issue on shut down/suspend to disk
• Next by Date: Re: [patch] implement smarter atime updates support, v2
• Previous by thread: Re: [PATCH] Off-by-one in /sys/module/*/refcnt
• Next by thread: [PATCH v2] Off-by-one in /sys/module/*/refcnt
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]