Re: [PATCH] fs/partitions/check.c: add_partition() warning fixes

Hi Cornelia,

Cornelia Huck wrote:
> On Sun, 29 Jul 2007 10:53:39 +0800,
> Eugene Teo <[email protected]> wrote:
[...]
>> +	return;
>> +
>> +err_out_del_link:
>> +	sysfs_remove_link(&p->kobj, "subsystem");
> 
> You need a remove uevent if you did an add uevent above.
> 
>> +err_out_del_kobj:
>> +	kobject_del(&p->kobj);
>> +err_out:
>> +	kfree(p);
> 
> Please use kobject_put() instead.

Thanks for your feedback.

Eugene
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] fs/partitions/check.c: add_partition() warning fixes
    • From: Eugene Teo <[email protected]>
  • Re: [PATCH] fs/partitions/check.c: add_partition() warning fixes
    • From: Cornelia Huck <[email protected]>

• Prev by Date: Re: [PATCH -rt 7/9] introduce PICK_FUNCTION
• Next by Date: Re: serial flow control appears broken
• Previous by thread: Re: [PATCH] fs/partitions/check.c: add_partition() warning fixes
• Next by thread: [PATCH] bsg: Fix warning with CONFIG_BLK_DEV_BSG=n
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]