On Wed, Jul 18, 2007 at 04:03:05PM -0400, Jeff Garzik wrote:
> Greg KH wrote:
> > On Tue, Jul 17, 2007 at 05:42:39PM -0400, Jeff Garzik wrote:
> >> commit ae97fec3701a559929c3529e35417fab133a4d39
> >> Author: Jeff Garzik <[email protected]>
> >> Date: Tue Jul 17 01:08:29 2007 -0400
> >>
> >> drivers/usb/misc/auerswald: fix status check, remove redundant check
> >> 1) We should only set 'actual_length' output variable if usb
> >> length is
> >> known to be good.
> >> 2) No need to check actual_length for NULL. The only caller
> >> always
> >> passes non-NULL value.
> >> Signed-off-by: Jeff Garzik <[email protected]>
> > I have no objection to this patch at all, however it does not remove the
> > compiler warning :(
>
> The description doesn't say it removes a warning, so it doesn't :)
>
> You want to look at
>
> drivers/*: mark variables with uninitialized_var()
>
> which was in posting "[git patches 2/2] warnings: use uninitialized_var()"
> and is now upstream commit a6343afb6e16b65b9f0b264f94f8207212e7e3ae
Ah, sorry, I just went for the first USB change entry, sorry about that
:)
And thanks for doing this, clean builds are good to have.
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
