Re: [PATCH] introduce __init_exit function annotation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Tue, 17 Jul 2007 17:14:32 +0200,
Sam Ravnborg wrote:
> 
> On Tue, Jul 17, 2007 at 04:52:12PM +0200, Takashi Iwai wrote:
> > At Tue, 17 Jul 2007 15:02:30 +0200,
> > Sam Ravnborg wrote:
> > > 
> > > On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote:
> > > > Introduce __init_exit, which is useful ie. for drivers that call
> > > > cleanup functions when they fail in __init functions.
> > > 
> > > This is wrong.
> > > On arm (just one example of several) the __exit section are discarded
> > > at buildtime so any reference from __init to __exit will cause the
> > > linker to error out.
> > 
> > Hmm, from what I see, it adds __init to the function.  There is no
> > reference to __exit.
> 
> The cleanup functions are marked __exit in the referenced case.

My understanding is that it's the very purpose of this patch --
change the mark from __exit to __init_exit for such clean-up
functions.


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux