Re: [PATCH] splice: fix wrong __splice_from_pipe() usage

On Mon, Jul 16 2007, OGAWA Hirofumi wrote:
> Hi,
> 
> I've noticed the nfsd read corruption by recent change. And this patch
> fixes the problem for me, is this right fix?
> -- 
> OGAWA Hirofumi <[email protected]>
> 
> 
> __splice_from_pipe() is updating the sd->pos for the actor, but those
> functions are passing the sd of reader side directory. So, splice
> updates sd->pos twice.
> 
> This fixes usage of __splice_from_pipe().

For sendfile() usage, or the nfsd path that uses splice to send?

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] splice: fix wrong __splice_from_pipe() usage
    • From: OGAWA Hirofumi <[email protected]>

• References:
  • [PATCH] splice: fix wrong __splice_from_pipe() usage
    • From: OGAWA Hirofumi <[email protected]>

• Prev by Date: Re: [patch 1/5] avoid tlb gather restarts.
• Next by Date: Re: [2.6 patch] the scheduled ACPI_PROCFS removal
• Previous by thread: [PATCH] splice: fix wrong __splice_from_pipe() usage
• Next by thread: Re: [PATCH] splice: fix wrong __splice_from_pipe() usage
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]