On Sun, 2007-07-15 at 20:59 +0100, Al Viro wrote:
> Going through the string and waiting for _pointer_ to become '\0'
> is not what the authors meant...
>
> Signed-off-by: Al Viro <[email protected]>
> ---
> drivers/ieee1394/nodemgr.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ieee1394/nodemgr.c b/drivers/ieee1394/nodemgr.c
> index c4d3d41..51a1206 100644
> --- a/drivers/ieee1394/nodemgr.c
> +++ b/drivers/ieee1394/nodemgr.c
> @@ -283,7 +283,7 @@ static ssize_t fw_show_##class##_##td_kv (struct device *dev, struct device_attr
> memcpy(buf, \
> CSR1212_TEXTUAL_DESCRIPTOR_LEAF_DATA(class->td_kv), \
> len); \
> - while ((buf + len - 1) == '\0') \
> + while (buf[len - 1] == '\0') \
> len--; \
> buf[len++] = '\n'; \
> buf[len] = '\0'; \
ACK
Definitely looks right with your patch. Thanks.
--
Ubuntu : http://www.ubuntu.com/
Linux1394: http://wiki.linux1394.org/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
