Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member

Hi Stephen,

On Thu, 5 Jul 2007, Stephen Hemminger wrote:
> On Wed, 4 Jul 2007 08:56:42 -0500
> Matt Mackall <[email protected]> wrote:
> [...]
> > > +	if (nt->dev_status) {
> > 
> > Why not simply call net_dev_is_up?
> 
> The flags field values are really BSD legacy-ish stuff and should not be
> used internally. IFF_UP etc, do not have the necessary atomic properties.
> 
> Use netif_running() instead.

Ok, thanks for letting me know about that. I'll make the change.

Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC][PATCH -mm 0/9] netconsole: Multiple targets and dynamic reconfigurability
    • From: Satyam Sharma <[email protected]>
  • [PATCH -mm 5/9] netconsole: Introduce dev_status member
    • From: Satyam Sharma <[email protected]>
  • Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member
    • From: Matt Mackall <[email protected]>
  • Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member
    • From: Stephen Hemminger <[email protected]>

• Prev by Date: Re: [PATCH] configfs: Convert subsystem semaphore to mutex
• Next by Date: Re: [linux-pm] Re: [PATCH] Remove process freezer from suspend to RAM pathway
• Previous by thread: Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member
• Next by thread: Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]