Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM

> check_signature() needs readb() but with some setups (s390, m68k allmodconfig)
> there is no implementation of readb.  This causes build errors with
> -Werror-implicit-function-declaration.

This completely bogus. readb() should be present on M68K, fix the
platform to implement readb() for MMIO, even if your MMIO readb is a
moveb instruction.

check_signature is relevant for anything with MMIO space (for example you
can legitimately want to check_signature a MAC68K Nubus ROM).

S/390 is a bit of a special case as no S/390 usage of check_signature
appears sane but equally it isn't used so you can stub it out.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM
    • From: Geert Uytterhoeven <[email protected]>
  • Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM
    • From: Roman Zippel <[email protected]>
  • Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM
    • From: Jeff Dike <[email protected]>

• References:
  • 2.6.22-rc6-mm1
    • From: Andrew Morton <[email protected]>
  • [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM
    • From: Heiko Carstens <[email protected]>
  • Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM
    • From: Andrew Morton <[email protected]>
  • Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM
    • From: Geert Uytterhoeven <[email protected]>
  • Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM
    • From: Andrew Morton <[email protected]>
  • Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM
    • From: Geert Uytterhoeven <[email protected]>
  • Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM
    • From: Andrew Morton <[email protected]>

• Prev by Date: [PATCH] PM: Reduce code duplication between main.c and user.c (updated)
• Next by Date: Re: New format Intel microcode...
• Previous by thread: Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM
• Next by thread: Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]