Re: [patch 1/3] add the fsblock layer

Nick Piggin <[email protected]> writes:


[haven't read everything, just commenting on something that caught my eye]

> +struct fsblock {
> +	atomic_t	count;
> +	union {
> +		struct {
> +			unsigned long	flags; /* XXX: flags could be int for better packing */

int is not supported by many architectures, but works on x86 at least.

Hmm, could define a macro DECLARE_ATOMIC_BITMAP(maxbit) that expands to the smallest
possible type for each architecture. And a couple of ugly casts for set_bit et.al.
but those could be also hidden in macros. Should be relatively easy to do.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 1/3] add the fsblock layer
    • From: Nick Piggin <[email protected]>
  • Re: [patch 1/3] add the fsblock layer
    • From: Arjan van de Ven <[email protected]>

• References:
  • [RFC] fsblock
    • From: Nick Piggin <[email protected]>
  • [patch 1/3] add the fsblock layer
    • From: Nick Piggin <[email protected]>

• Prev by Date: Re: [PATCH] hw_random: add quality categories
• Next by Date: Re: [PATCH] hw_random: add quality categories
• Previous by thread: [patch 1/3] add the fsblock layer
• Next by thread: Re: [patch 1/3] add the fsblock layer
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]