Re: [PATCH] net: Make skb_seq_read unmap the last fragment

From: Olaf Kirch <[email protected]>
Date: Tue, 19 Jun 2007 09:56:24 +0200

> From: Olaf Kirch <[email protected]>
> 
> Make skb_seq_read unmap the last fragment
> 
> Having walked through the entire skbuff, skb_seq_read would leave the
> last fragment mapped.  As a consequence, the unwary caller would leak
> kmaps, and proceed with preempt_count off by one. The only (kind of
> non-intuitive) workaround is to use skb_seq_read_abort.
> 
> This patch makes sure skb_seq_read always unmaps frag_data after having
> cycled through the skb's paged part.
> 
> Signed-off-by: [email protected]

Thanks for finding and fixing this bug.

Patch applied, thanks again Olaf.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] net: Make skb_seq_read unmap the last fragment
    • From: Olaf Kirch <[email protected]>

• Prev by Date: Re: [RFC] [PATCH 2.6.21.5] ppp: fix osize too small errors when decoding mppe
• Next by Date: it's iwl3945 [Re: can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]
• Previous by thread: [PATCH] net: Make skb_seq_read unmap the last fragment
• Next by thread: xfs freeze/umount problem
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]