Re: NAK (bashizm in the /bin/sh script): [PATCH v3] doc/oops-tracing: add Code: decode info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Adrian Bunk wrote:
On Sat, Jun 23, 2007 at 10:56:45AM -0700, Andrew Morton wrote:
On Sat, 23 Jun 2007 10:43:03 -0700 Randy Dunlap <[email protected]> wrote:

NAK.
Sorry I slept thru another wonderful festival on LKML.
That's probably the best strategy.

You don't have the authority to NAK the patch.
Yeah.  nak to naks.

OTOH, you also didn't supply a patch.  If you do this, I'll be
glad to consider it.  If I can read it, that is.
Yes, I plan on merging that patch as-is.  If it was a compulsory part of
kbuild then that would be a problem but as some optional tool I don't think
that a bashism matters much.  Someone can fix it sometime should they feel
so motivated.

Oleg didn't express it very polite, but he has a valid point that bash scripts should start with "#!/bin/bash" since /bin/sh might be some shell other than bash.

Randy, am I right to assume that such a change to your patch would be OK?

Sure.

--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux