Re: [PATCH] Alternative fix for kprobes&DEBUG_RODATA was Re: [1/2] 2.6.22-rc5: known regressions with patches

On Thu, 21 Jun 2007, Andi Kleen wrote:

> Ok, here's a patch to do this. With that 55181000cd60334fe920c65ffbcdfe0e3f1de406
> should be reverted because it isn't needed anymore.

This seems buggy:

> +	int notext = 0;
>  
> +#ifdef CONFIG_KPROBES
> +	notext = 1;
> +#endif
>  #ifdef CONFIG_HOTPLUG_CPU
>  	/* It must still be possible to apply SMP alternatives. */
> -	if (num_possible_cpus() <= 1)
> +	notext = (num_possible_cpus() > 1);
>  #endif

The CONFIG_HOTPLUG_CPU case will overwrite the CONFIG_KPROBES, and turn it 
back to zero for a single CPU.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [1/2] 2.6.22-rc5: known regressions with patches
    • From: Michal Piotrowski <[email protected]>
  • Re: [1/2] 2.6.22-rc5: known regressions with patches
    • From: Dave Jones <[email protected]>
  • Re: [1/2] 2.6.22-rc5: known regressions with patches
    • From: Linus Torvalds <[email protected]>
  • [PATCH] Alternative fix for kprobes&DEBUG_RODATA was Re: [1/2] 2.6.22-rc5: known regressions with patches
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: [BUG] long freezes on thinkpad t60
• Next by Date: [PATCH] signed binaries support [0/4]
• Previous by thread: [PATCH] Alternative fix for kprobes&DEBUG_RODATA was Re: [1/2] 2.6.22-rc5: known regressions with patches
• Next by thread: Re: [1/2] 2.6.22-rc5: known regressions with patches
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]