Re: [PATCH] create_new_namespaces: fix improper return of NULL

Oleg Nesterov wrote:
> On 06/19, Cedric Le Goater wrote:
>> Oleg Nesterov wrote:
>>> Untested.
>>>
>>> dup_mnt_ns() and clone_uts_ns() return NULL on failure. This is wrong,
>>> create_new_namespaces() uses ERR_PTR() to catch an error. This means
>>> that the subsequent create_new_namespaces() will hit BUG_ON() in
>>> copy_mnt_ns() or copy_utsname().
>> I sent one just like it :
>>
>> 	http://lkml.org/lkml/2007/6/12/142
> 
> Ah, thanks.
> 
> Your patch is more complete, it also fixes kernel/user_namespace.c (which
> I don't see in 2.6.22-rc5). I don't this this fix is urgent, so...

This patch applies on top of previous i've sent to andrew. 
kernel/user_namespace.c should be in -mm.

Thanks,

C. 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] create_new_namespaces: fix improper return of NULL
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] create_new_namespaces: fix improper return of NULL
    • From: Cedric Le Goater <[email protected]>
  • Re: [PATCH] create_new_namespaces: fix improper return of NULL
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: Re: Error -71 on device descriptor read/all
• Next by Date: Re: [BUG] ide dma_timer_expiry, then hard lockup
• Previous by thread: Re: [PATCH] create_new_namespaces: fix improper return of NULL
• Next by thread: strange queue_if_no_path behavior
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]