Re: [PATCH] blink: Only blink when parameter is set

Bernhard Walle wrote:

* Randy Dunlap <[email protected]> [2007-06-18 06:26]:

+static int blink = 0;

no need to init to 0.

Does it harm?

It adds space to the binary file in some cases and it is kernel
convention not to init statics to NULL or 0 since that is already
guaranteed for them.

+module_param(blink, bool, S_IRUGO);
+MODULE_PARM_DESC(blink, "Enable blinking (without that, the module does nothing)\n");

unneeded "\n"

Fixed. Please use the following patch.

--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] blink: Only blink when parameter is set
    • From: Bernhard Walle <[email protected]>
  • Re: [PATCH] blink: Only blink when parameter is set
    • From: Randy Dunlap <[email protected]>
  • Re: [PATCH] blink: Only blink when parameter is set
    • From: Bernhard Walle <[email protected]>

• Prev by Date: Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
• Next by Date: Re: [fuse-devel] FS block count, size and seek offset?
• Previous by thread: Re: [PATCH] blink: Only blink when parameter is set
• Next by thread: Re: [PATCH] blink: Only blink when parameter is set
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]