[PATCH] Oddity in mxcsr_feature_mask_init()

Hi,

In arch/i386/kernel/i387.c:mxcsr_feature_mask_init(), one can read:

	asm volatile("fxsave %0" : : "m" (current->thread.i387.fxsave)); 

But I would rather have written:

	asm("fxsave %0" : "=m" (current->thread.i387.fxsave)); 

Considering the code around, it doesn't do much difference, but it makes
more sense (i.e. we just fill fxsave).

Samuel

Signed-off-by: Samuel Thibault <[email protected]>

--- linux-2.6.21-orig/arch/i386/kernel/i387.c.orig	2007-06-08 18:18:10.000000000 +0800
+++ linux-2.6.21-orig/arch/i386/kernel/i387.c	2007-06-08 18:18:22.000000000 +0800
@@ -32,7 +32,7 @@
 	clts();
 	if (cpu_has_fxsr) {
 		memset(&current->thread.i387.fxsave, 0, sizeof(struct i387_fxsave_struct));
-		asm volatile("fxsave %0" : : "m" (current->thread.i387.fxsave)); 
+		asm("fxsave %0" : "=m" (current->thread.i387.fxsave)); 
 		mask = current->thread.i387.fxsave.mxcsr_mask;
 		if (mask == 0) mask = 0x0000ffbf;
 	} 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Prev by Date: Re: serio interface
• Next by Date: Re: O_CLOEXEC: An alternate proposal
• Previous by thread: [patch-stable 0/3] Futex fixes for stable
• Next by thread: [PATCH 1/1] leds: LED Bitpattern Trigger
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]