Brice Goglin wrote:
Steve Wise wrote:
You're right. But cxgb3 has it now in the driver (tested and working).
Shouldn't it be pulled in? When the network stack design gets done
(which could take a few releases to finalize), all the drivers can be
updated to use it. It doesn't seem reasonable to allow some drivers to
support LRO and others to not support it...
I have to agree with Steve here. We have been requesting the inclusion
of myri10ge LRO for 5 months now (before 2.6.19). I could understand
that duplicating LRO code between s2io and myri10ge was not a good idea
at this point. But, I now see that Netxen got merged way later (in
2.6.20) but it got its LRO merged immediately. I guess the LRO is
already duplicated between s2io and netxen then. It does not look fair
to me at all.
It was an error on my part, that should not be compounded. Three wrongs
don't make a right, etc., etc.
The normal way this stuff works in Linux is that people work together to
create common code that everybody uses. I would gladly accept patches
to rip out the code from NetXen.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
