Re: [PATCH 1/3] Preserve the dirty bit in init_page_buffers

Eric W. Biederman wrote:

Nick Piggin <[email protected]> writes:

However we
could still set_page_dirty of a block device page without buffers
via an mmap.

After the page is made dirty via mmap we have:
sys_write -> ... -> block_prepare_write -> ... -> create_empty_buffers.

Yep, that's what I mean.

I suspect that is a pretty rare case but it does indeed seem to exist
as a problem.

I think so too. But either we have some misunderstanding of the
codepaths involved, or the author of the comments there didn't
consider this case, so...

--
SUSE Labs, Novell Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/3] Preserve the dirty bit in init_page_buffers
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 1/3] Preserve the dirty bit in init_page_buffers
    • From: [email protected] (Eric W. Biederman)

• References:
  • [PATCH 1/3] Preserve the dirty bit in init_page_buffers
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 1/3] Preserve the dirty bit in init_page_buffers
    • From: Nick Piggin <[email protected]>
  • Re: [PATCH 1/3] Preserve the dirty bit in init_page_buffers
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 1/3] Preserve the dirty bit in init_page_buffers
    • From: Nick Piggin <[email protected]>
  • Re: [PATCH 1/3] Preserve the dirty bit in init_page_buffers
    • From: Nick Piggin <[email protected]>
  • Re: [PATCH 1/3] Preserve the dirty bit in init_page_buffers
    • From: [email protected] (Eric W. Biederman)

• Prev by Date: Re: [PATCH 2.6.21] cramfs: add cramfs Linear XIP
• Next by Date: Re: Network broken in kernel level.
• Previous by thread: Re: [PATCH 1/3] Preserve the dirty bit in init_page_buffers
• Next by thread: Re: [PATCH 1/3] Preserve the dirty bit in init_page_buffers
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]